Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: regression on help file hovering #808

Closed
3 tasks done
julio-b opened this issue May 20, 2023 · 0 comments · Fixed by #809
Closed
3 tasks done

bug: regression on help file hovering #808

julio-b opened this issue May 20, 2023 · 0 comments · Fixed by #809
Labels
bug Something isn't working

Comments

@julio-b
Copy link

julio-b commented May 20, 2023

Did you check docs and existing issues?

  • I have read all the lazy.nvim docs
  • I have searched the existing issues of lazy.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.9.0

Operating system/version

archlinux

Describe the bug

When pressing <K> on a plugin's help file, the floating lazy window does not close. Instead, Lazy remains open for the rest of the session and cannot be focused again unless you force close it using :bd <bufnum>

bad2.mp4

Steps To Reproduce

  1. nvim -u repro.lua
  2. :Lazy<CR>
  3. go to a plugin that has a help file like |tokyonight.nvim.txt|
  4. Press <K>
  5. help file opens behind lazy and lazy becomes unfocusable

Expected Behavior

Lazy window should close immediately after opening the help file. Alternatively, lazy should handle help files in a similar manner to how it handles git diffs.

Git bisect gave me commit 7339145. Lazy works as expected after reverting it:

good.mp4

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@julio-b julio-b added the bug Something isn't working label May 20, 2023
@folke folke closed this as completed in cc7a764 May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant