Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartmove doesnt work well with cmp #130

Closed
folke opened this issue Oct 26, 2022 · 4 comments · Fixed by #639
Closed

smartmove doesnt work well with cmp #130

folke opened this issue Oct 26, 2022 · 4 comments · Fixed by #639
Labels
bug Something isn't working

Comments

@folke
Copy link
Owner

folke commented Oct 26, 2022

We should add an exlcude list of filetypes that are ok to overlap.

@folke
Copy link
Owner Author

folke commented Oct 26, 2022

@wangl-cc I can't repdoduce this. What do you do to trigger it?

@wangl-cc
Copy link
Contributor

wangl-cc commented Oct 26, 2022

I trigger it when the cmdline change,like type :h or :lua.

2022-10-27.01.54.39.mov

@quantum-booty
Copy link

quantum-booty commented Oct 26, 2022

I can reproduce this too.
image

@folke folke closed this as completed in c63267d Oct 26, 2022
@folke
Copy link
Owner Author

folke commented Oct 26, 2022

Should be fixed. I've added the filetype exlcusions and also only do the smart move when the overlapping area is larger than 30%.

There's always windows without filetypes. Like the packer cofirm dialog, shade window, cmp scrollbars, ...

The area check should cover most of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants