Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use msg_clear to determine message state #164

Closed
folke opened this issue Oct 29, 2022 · 0 comments · Fixed by #209
Closed

Don't use msg_clear to determine message state #164

folke opened this issue Oct 29, 2022 · 0 comments · Fixed by #209
Labels
enhancement New feature or request

Comments

@folke
Copy link
Owner

folke commented Oct 29, 2022 •
edited
Loading

Currently, message state is maintained by relying on Neovim message state (msg_clear).

It would be better to handle this by Noice using configurable timeouts.

This would make some of the code easier to work with and would fix some issues with messgages expiring before they have been displayed. (this can happen in async contexts like timers)
@folke folke added the enhancement New feature or request label Oct 29, 2022
@folke folke changed the title Don't use Neovim state to determine if a message is cleared or still active Don't use Neovim msg_clear to determine message state Oct 29, 2022
@folke folke changed the title Don't use Neovim msg_clear to determine message state Don't use msg_clear to determine message state Oct 29, 2022
This was referenced Nov 9, 2022
Closed
Merged
@folke folke linked a pull request Nov 10, 2022 that will close this issue
feat: manage message state without msg_clear #209
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: manage message state without msg_clear folke/noice.nvim
1 participant
@folke