Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag when quitting Neovim #237

Closed
serhez opened this issue Nov 21, 2022 · 7 comments · Fixed by #257 or #639
Closed

Lag when quitting Neovim #237

serhez opened this issue Nov 21, 2022 · 7 comments · Fixed by #257 or #639
Labels
bug Something isn't working

Comments

@serhez
Copy link

serhez commented Nov 21, 2022

Describe the bug
Exiting nvim using :q is quite slow when using Noice.

Which version of Neovim are you using?
Nvim 0.8.0 on WezTerm

To Reproduce
Steps to reproduce the behavior:

  1. Install Noice
  2. Quit neovim (:q)

Expected Behavior
I would expect to not have lag when quitting neovim when using Noice.

Noice Log
N/A.

@serhez serhez added the bug Something isn't working label Nov 21, 2022
@serhez
Copy link
Author

serhez commented Nov 21, 2022

Here is my config:

require("noice").setup({
	health = {
		checker = false, -- Disable if you don't want health checks to run
	},

	cmdline = {
		view = "cmdline",
	},

	override = {
		-- override the default lsp markdown formatter with Noice
		["vim.lsp.util.convert_input_to_markdown_lines"] = true,
		-- override the lsp markdown formatter with Noice
		["vim.lsp.util.stylize_markdown"] = true,
		-- override cmp documentation with Noice (needs the other options to work)
		["cmp.entry.get_documentation"] = true,
	},

	views = {
		hover = {
			border = {
				style = "single",
			},
			position = { row = 2, col = 2 },
		},
	},

	-- Do not show normal messages
	routes = {
		{
			filter = {
				event = "msg_show",
			},
			opts = { skip = true },
		},
	},
})

@serhez
Copy link
Author

serhez commented Nov 21, 2022

With Noice:

Screen.Recording.2022-11-21.at.14.05.09.mov

@serhez
Copy link
Author

serhez commented Nov 21, 2022

Without Noice:

Screen.Recording.2022-11-21.at.14.13.41.mov

@folke
Copy link
Owner

folke commented Nov 21, 2022

I think I fixed that yesterday. Are you using the latest version?

@serhez
Copy link
Author

serhez commented Nov 21, 2022

@folke yes, I am using the latest version (including some commits you merged in the last few hours). The problem is still there for me. Thanks for having a look!

@folke folke closed this as completed in 8c8acf7 Dec 3, 2022
@folke
Copy link
Owner

folke commented Dec 3, 2022

I think I was able to fix this. If not, can you post your Noice log?

@serhez
Copy link
Author

serhez commented Dec 3, 2022

It works like a charm now, it seems fixed to me. Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants