chore: update healthcheck #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- *health#report_error* *vim.health.report_error()* Use |vim.health.error()| instead. - *health#report_info* *vim.health.report_info()* Use |vim.health.info()| instead. - *health#report_ok* *vim.health.report_ok()* Use |vim.health.ok()| instead. - *health#report_start* *vim.health.report_start()* Use |vim.health.start()| instead. - *health#report_warn* *vim.health.report_warn()* Use |vim.health.warn()| instead.
folke
requested changes
Apr 22, 2023
There was a problem hiding this comment.
This will break noice for older Neovim versions.
Can you update the code so it uses the below?
local start = vim.health.start or vim.health.report_start
local ok = vim.health.ok or vim.health.report_ok
local warn = vim.health.warn or vim.health.report_warn
local error = vim.health.error or vim.health.report_error
🫡Fair point. I had thought of that, but since using the nightly build is highly recommended, I thought this would be pretty safe. |
|
thanks! |
willothy
pushed a commit
to willothy/noice.nvim
that referenced
this pull request
Aug 19, 2023
* chore: update healthcheck - *health#report_error* *vim.health.report_error()* Use |vim.health.error()| instead. - *health#report_info* *vim.health.report_info()* Use |vim.health.info()| instead. - *health#report_ok* *vim.health.report_ok()* Use |vim.health.ok()| instead. - *health#report_start* *vim.health.report_start()* Use |vim.health.start()| instead. - *health#report_warn* *vim.health.report_warn()* Use |vim.health.warn()| instead. * Allow for use of legacy health checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
health api was changed in #22927