Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: progress use vim.lsp.get_client_by_id #529

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: progress use vim.lsp.get_client_by_id #529

merged 1 commit into from
Jun 30, 2023

Conversation

armed
Copy link
Contributor

@armed armed commented Jun 30, 2023

Some language servers are not in active list until initialization is done.
For example clojure_lsp sends $/progress messages and activates itself (i.e. becomes available as active client) only when initialization is complete. In this case get_active_clients returns empty table. But get_client_by_id returns clojure client.

This PR replaces vim.lsp.get_active_clients with vim.lsp.get_client_by_id in progress handler.

@folke folke merged commit 397619d into folke:main Jun 30, 2023
@folke
Copy link
Owner

folke commented Jun 30, 2023

thanks!

willothy pushed a commit to willothy/noice.nvim that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants