bug: global conceallevel modified by search

[rliebz]

Did you check docs and existing issues?

• I have read all the noice.nvim docs
• I have searched the existing issues of noice.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.9.4

Operating system/version

macOS 14.0

Describe the bug

When enabling both noice and oil.nvim, the global conceallevel is modified after using the search function in an oil buffer. I suspect this behavior would occur in other situations where window-local options are set, but the included example uses oil.nvim because that's where I encountered it.

I'm not particularly well versed in how set/setlocal/setglobal options vs. window/buffer options are meant to work, but my guess is that the issue is here:

noice.nvim/lua/noice/util/hacks.lua

Lines 55 to 79 in 8f1b53a

	---@see https://github.com/neovim/neovim/issues/17810
	function M.fix_incsearch()
	---@type integer|nil
	local conceallevel
	vim.api.nvim_create_autocmd("CmdlineEnter", {
	group = M.group,
	callback = function(event)
	if event.match == "/" or event.match == "?" then
	conceallevel = vim.wo.conceallevel
	vim.wo.conceallevel = 0
	end
	end,
	})
	vim.api.nvim_create_autocmd("CmdlineLeave", {
	group = M.group,
	callback = function(event)
	if conceallevel and (event.match == "/" or event.match == "?") then
	vim.wo.conceallevel = conceallevel
	conceallevel = nil
	end
	end,
	})
	end

Where setting vim.wo.conceallevel also modifies vim.go.conceallevel.

From reading the help docs I think this might be more appropriate:

-vim.wo.conceallevel = conceallevel
+vim.api.nvim_set_option_value('conceallevel', conceallevel, { scope = 'local' })

And seems to fix the issue I'm experiencing locally, but figured I'd report the behavior and explain my reasoning rather than submit the fix as a guess when I don't fully understand what the other implications of that change my might be.

Steps To Reproduce

1. nvim -u repro.lua .
   • You may need to exit and run this again, oil doesn't seem to hijack the file explorer in the same session that it's installed
2. := vim.go.conceallevel
   • Prints 0
3. / <esc>
   • When you type /, the conceallevel will change and numbers will be visible to the left of files in the directory
   • When you press <esc>, the conceallevel will revert to its previous value
   • No need to search for any text or confirm
4. := vim.go.conceallevel
   • Prints 3

Expected Behavior

The global conceallevel should be restored to its original value (0) after the search command finishes.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
	vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
	vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
	"folke/tokyonight.nvim",
	{
		"folke/noice.nvim",
		dependencies = {
			"MunifTanjim/nui.nvim",
		},
		opts = {},
	},
	-- add any other plugins here
	{ "stevearc/oil.nvim", opts = {} },
}
require("lazy").setup(plugins, {
	root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here