Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: LspProgress change in recent neovim commits #793

Closed
3 tasks done
embe221ed opened this issue May 8, 2024 · 5 comments · Fixed by #785
Closed
3 tasks done

bug: LspProgress change in recent neovim commits #793

embe221ed opened this issue May 8, 2024 · 5 comments · Fixed by #785
Labels
bug Something isn't working

Comments

@embe221ed
Copy link

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

NVIM v0.10.0-dev-3097+g064f3e42e

Operating system/version

MacOS

Describe the bug

neovim/neovim@e14e750

Steps To Reproduce

open *.lua file with lsp progress feature enabled

Expected Behavior

no errors

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "folke/noice.nvim",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here
@embe221ed embe221ed added the bug Something isn't working label May 8, 2024
@embe221ed
Copy link
Author

diff --git a/lua/noice/lsp/progress.lua b/lua/noice/lsp/progress.lua
index 257dc6a..11689cc 100644
--- a/lua/noice/lsp/progress.lua
+++ b/lua/noice/lsp/progress.lua
@@ -16,7 +16,7 @@ M._running = false
 ---@param data {client_id: integer, result: lsp.ProgressParams}
 function M.progress(data)
   local client_id = data.client_id
-  local result = data.result
+  local result = data.params
   local id = client_id .. "." .. result.token

   local message = M._progress[id]

@embe221ed
Copy link
Author

created this as a heads up, didn't want to create a PR as I think this is not an issue for now, but will be in the future once this commit is included in the release

@ulisses-cruz
Copy link

This is already an issue for me

@carlosala
Copy link

Yep, it's already on nightly.

@gldtn
Copy link

gldtn commented May 8, 2024

This is already an issue for me

Same, hoping the PR(#785) gets accepted soon 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants