Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: mini.jump t doesn't work if the following key comes too late when using with noice.nvim #827

Open
3 tasks done
Frederick888 opened this issue May 28, 2024 · 13 comments
Labels
bug Something isn't working

Comments

@Frederick888
Copy link

Did you check docs and existing issues?

  • I have read all the noice.nvim docs
  • I have searched the existing issues of noice.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.10.0

Operating system/version

macOS 14.5

Describe the bug

Since I had issues with clever-f (#824), I tried https://github.com/echasnovski/mini.jump, and I noticed that if I e.g. dt, then wait for one second or two, and then hit another key, it does nothing.

Steps To Reproduce

  1. nvim -u repro.lua repro.lua
  2. Hit dt
  3. Wait for a second or two (Without noice.nvim, it shows (mini.jump) Enter target single character _ in cmd area. This might be relevant?)
  4. Hit another key

Expected Behavior

It deletes contents until the character given by the third key.

Repro

-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  "MunifTanjim/nui.nvim",
  "folke/noice.nvim",
  -- "rhysd/clever-f.vim",
  "echasnovski/mini.jump",
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

require("noice").setup({
  lsp = {
    -- override markdown rendering so that **cmp** and other plugins use **Treesitter**
    override = {
      ["vim.lsp.util.convert_input_to_markdown_lines"] = true,
      ["vim.lsp.util.stylize_markdown"] = true,
      ["cmp.entry.get_documentation"] = true, -- requires hrsh7th/nvim-cmp
    },
  },
  -- you can enable a preset for easier configuration
  presets = {
    bottom_search = true, -- use a classic bottom cmdline for search
    command_palette = true, -- position the cmdline and popupmenu together
    long_message_to_split = true, -- long messages will be sent to a split
    inc_rename = false, -- enables an input dialog for inc-rename.nvim
    lsp_doc_border = false, -- add a border to hover docs and signature help
  },
})

require('mini.jump').setup()
@Frederick888 Frederick888 added the bug Something isn't working label May 28, 2024
@Frederick888
Copy link
Author

I did a bisect and the first bad commit was a0c6203.

This particular issue was gone after checking out a0c6203d551242322ac7995b26d4e320140e05b1~. There were some minor glitches:

  1. If I do the dt -> wait -> another flow key before the first mini view pops up (using the timer from bug: E565: Not allowed to change text or change window error when using with clever-f.vim #824's repro.lua), there won't be any mini views showing at all
  2. If I do the flow after the mini views started popping up, it'll pause the pop-ups, move the existing pop-ups to the left (to accommodate (mini.jump) Enter target single character _ presumably), show (mini.jump) Enter target single character _ after I hit the third key and resume
  3. The pop-ups lose highlights during the wait between dt and the third key

It seems #824 is the same issue, as checking out a0c6203d551242322ac7995b26d4e320140e05b1~ resolved it too.

Copy link
Contributor

github-actions bot commented Jul 6, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 6, 2024
@Frederick888
Copy link
Author

Just tested again and it was still reproducible.

@github-actions github-actions bot removed the stale label Jul 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 7, 2024
@Frederick888
Copy link
Author

Just tested again and it was still reproducible. (Sorry for the noise. haven't got the permission to remove labels.)

@github-actions github-actions bot removed the stale label Aug 8, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Sep 7, 2024
@Frederick888
Copy link
Author

Just validated again, still had the issue

@github-actions github-actions bot removed the stale label Sep 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Oct 9, 2024
@Frederick888
Copy link
Author

Remove stale.

@github-actions github-actions bot removed the stale label Oct 12, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Nov 11, 2024
@Frederick888
Copy link
Author

Remove stale.

@github-actions github-actions bot removed the stale label Nov 14, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Dec 14, 2024
@Frederick888
Copy link
Author

Remove stale.

@github-actions github-actions bot removed the stale label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant