bug: Cursor flickering in cmdline

[TommyCox]

Did you check docs and existing issues?

• I have read all the noice.nvim docs
• I have updated the plugin to the latest version before submitting this issue
• I have searched the existing issues of noice.nvim
• I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.10.1

Operating system/version

Linux 6.6.41

Describe the bug

Cusor flickers in cmdline with "g/pattern" commands or "q:" command-line window open.

Steps To Reproduce

1. Open neovim with minimal init.
2. Ensure noice.nvim is installed and running.
3. Press :g/a.
4. Cursor begins to flicker.

Expected Behavior

Cursor does not flicker.

Repro

vim.env.LAZY_STDPATH = ".repro"
load(vim.fn.system("curl -s https://raw.githubusercontent.com/folke/lazy.nvim/main/bootstrap.lua"))()

require("lazy.minit").repro({
  spec = {
    {
      "folke/noice.nvim", 
      event = "VeryLazy",
      dependencies = { "MunifTanjim/nui.nvim" },
      opts = {
        cmdline = {
          view = "cmdline",
        },
      },
    }
  },
})

[TommyCox]

Probably related to #923.
The workaround of downgrading to 4.4.7 also worked for this issue.

[Nemexia]

i have the same problem on windows terminal using PowerShell

[mkubasz]

https://www.reddit.com/r/neovim/comments/1ewaq2u/comment/liy9hsu/?context=3
Same in my clean LazyVim instalation.

[cjasaMHC]

Ok, glad I'm not the only one noticing this. Same for NvChad with clean install

[panboo0106]

same here

[iamxiaojianzheng]

same here

[renxzen]

2024-09-01_00-56-02.mp4

presenting the same problem

[Nemexia]

unlike top video, mine starts exactly as i go to the bar

[azaidrahman]

Same here, also on Windows Terminal Powershell

#935

[Riddlerrr]

Same for me: neovim 10.1, macos

[echaya]

Same here, on Wezterm on windows and WSL

[fredizzimo]

Does this block of code need to call nvim__redraw(flush = true)? I think that's the main reason for the flickering, based on my initial analysis based on the Neovide logs here neovide/neovide#2735 (comment)

From the UI perspective a flush means that there's a valid UI state that should be shown. But here it's first flushing with a mouse movement and then move the mouse again.

vim.schedule_wrap(function()
      if not Util.is_search() then
        if vim.api.nvim__redraw then
          vim.api.nvim__redraw({ flush = true, cursor = true })
        else
          vim.cmd.redraw()
        end
      end
      Cmdline.fix_cursor()
    end)
end

[folke]

@fredizzimo nope, that was indeed wrong! Did a bad copy-paste from the cmdline code and forgot to remove the cursor = true.

Just pushed a new release, so should be fixed.

Weirdly enough the issue didn't show on Linux, but it did on Windows, MacOS and in Neovide.

[MarcoBuess]

Can confirm its fixed. Tyvm @folke @fredizzimo ❤️

[Riddlerrr]

Thank you @folke, I can confirm it is fixed on macos + neovim 👍

It was really painful to use cmdline with the flickering cursor.