Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to current window in jump_to_item #175

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

elkowar
Copy link
Contributor

@elkowar elkowar commented Apr 19, 2022

This PR fixes an error where sometimes, jump_to_item would crash in case the window-id was nil for some reason.
By just defaulting to 0 in that case, we can avoid that error trivially.
This error occurred when auto_jump was used.
The fix does not introduce any other breaking changes or behavior changes.

@hehelego
Copy link

hehelego commented Apr 26, 2022

Seems this plugin is no longger maintained and the creator haven't been active on github for months.
Perhaps we should start a maintained fork?

@kluen
Copy link

kluen commented Jul 10, 2022

I'm wondering if it would make more sense to find the places where we get nil values and fix them. On the one hand this change would make the errors disappear but also mask the true reasons, which could also be bugs.

@folke folke merged commit ec24219 into folke:main Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants