Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this should fix #240, #59, #209, and #189. It simply focuses
self.parent
before callingnvim_win_close()
in theView:close()
function. As far as I can tell, this function is only called when the Trouble window/list is closed (withq
or:TroubleToggle
or:TroubleClose
).I think this should be less likely to cause issues than the change in #72 that was reverted. That change modified
View:close_preview()
, which is called every time theBufLeave
autocmd is triggered, which (in addition to when closing the Trouble window) happens every time you select a diagnostic item in the Trouble window withReturn
.