Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telescope provider): (Smart) multiselect #39

Merged
merged 1 commit into from
May 27, 2021
Merged

feat(telescope provider): (Smart) multiselect #39

merged 1 commit into from
May 27, 2021

Conversation

runiq
Copy link
Contributor

@runiq runiq commented May 27, 2021

Adds support for Telescope's multiselect mode and smart select mode.

  • Multiselect: Only the selected entries are shown in Trouble.
  • Smart: If you have selected some entries, only those entries will be shown in Trouble. Otherwise all entries will be shown.

Adds support for Telescope's multiselect mode and smart select mode.
@folke folke merged commit 45ff198 into folke:main May 27, 2021
@folke
Copy link
Owner

folke commented May 27, 2021

Thanks man! I didn;t even know about the multi-select in Telescope. Super useful!

@Bruflot
Copy link

Bruflot commented May 27, 2021

This PR breaks Trouble if you don't have Telescope installed. The calls to require fail since none of the modules exist. Perhaps add an option to conditionally include the provider?

@folke

@runiq
Copy link
Contributor Author

runiq commented May 27, 2021

Oops, sorry for that! I'll add a check in a few minutes (on my way home right now).

@folke
Copy link
Owner

folke commented May 27, 2021

@Bruflot I just pushed a fix for this. It also gave issue when lazy-loading Telescope. Should be all fixed now!

@folke
Copy link
Owner

folke commented May 27, 2021

@runiq no worries, all fixed :) Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants