-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign rendering code seems to have an inverted condition #448
Comments
diagnostics signs on >= 0.10 should be configured through |
It seems rather odd to declare a non-deprecated API, literally everyone uses, obsolete and break existing configs for no apparent reason. With your pointer and the help of https://neovim.io/doc/user/diagnostic.html#diagnostic-signs I managed to adjust the config to support old and new style but since I couldn't find any tutorials or example configs using the "recommded" API, I think it will take a while until the world catches up... |
Allright, I'll see if I can just also use the old values if needed. |
I think I fixed it |
Can you check again? |
Looking good now. 👍🏻 |
Hi,
I was briefly looking into why trouble fails to render the correctly configured sign icons and instead uses the first letter of the severity instead.
It occured to me that this condition is wrong
trouble.nvim/lua/trouble/format.lua
Line 66 in 91cab16
since the else branch uses
vim.fn.sign_getdefined()
which does exist in nvim 0.10. Indeed flipping the condition makes trouble render the icon instead of the letter just fine.However I'm not sure there's no more correct way to do version checks since that first branch is probably supposed to be used for all older versions instead of all versions not being 0.10 and I'm not sure how those nvim feature flags work.
The text was updated successfully, but these errors were encountered: