Sign rendering code seems to have an inverted condition

[therealprof]

Hi,

I was briefly looking into why trouble fails to render the correctly configured sign icons and instead uses the first letter of the severity instead.

It occured to me that this condition is wrong

trouble.nvim/lua/trouble/format.lua

Line 66 in 91cab16

if vim.fn.has("nvim-0.10.0") == 1 then

since the else branch uses vim.fn.sign_getdefined() which does exist in nvim 0.10. Indeed flipping the condition makes trouble render the icon instead of the letter just fine.

However I'm not sure there's no more correct way to do version checks since that first branch is probably supposed to be used for all older versions instead of all versions not being 0.10 and I'm not sure how those nvim feature flags work.

[folke]

diagnostics signs on >= 0.10 should be configured through vim.diagnostic.config, not using sign_define

[folke]

#449

[therealprof]

It seems rather odd to declare a non-deprecated API, literally everyone uses, obsolete and break existing configs for no apparent reason. gitsigns, lualine, trouble v2 and other plugins work just fine with sign_define, only trouble v3 looks rather dated now.

With your pointer and the help of https://neovim.io/doc/user/diagnostic.html#diagnostic-signs I managed to adjust the config to support old and new style but since I couldn't find any tutorials or example configs using the "recommded" API, I think it will take a while until the world catches up...

[folke]

Allright, I'll see if I can just also use the old values if needed.

[folke]

I think I fixed it

[therealprof]

Doesn't look like it, with the latest main and after backing out the new configuration:

[folke]

Can you check again?

[therealprof]

Looking good now. 👍🏻