Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): avoid overwriting uri of result #60

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix(lsp): avoid overwriting uri of result #60

merged 1 commit into from
Jul 16, 2021

Conversation

rcarriga
Copy link
Contributor

Small fix to avoid issues with servers that respond with uri rather than targetUri

@folke
Copy link
Owner

folke commented Jul 16, 2021

Hi! Thank you for this PR!

Could you swap the or? so try target first and fallback to the normal one if it's nil.

Probably not needed, but better be safe :)

@rcarriga rcarriga force-pushed the fix/lsp/avoid-overwrite-uri branch from 22d688e to 0fc1e66 Compare July 16, 2021 17:56
@rcarriga
Copy link
Contributor Author

Sure thing! Done 👌

@folke folke merged commit 655391c into folke:main Jul 16, 2021
@github-actions github-actions bot mentioned this pull request Jan 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rcarriga @folke