Implement a "compact" flag

[WhyNotHugo]

This flag removes the header and extra spacing. It's suitable when using
lsp_document_diagnostics, where including the filename and collapse
icon is redundant (since there's only one file anyway).

I'm mostly using Trouble with lsp_document_diagnostics, so I only see errors for the current file. I'd rather keep the error split small and fit as much content as possible, and this helps with that goal.

The default behaviour remains the same, since the default is compact=false.

Let me know if the change seems too invasive. I'd also like to add a mode where only diagnostics for the current line are shown, and compact fits well with that.

[hanspinckaers]

Thanks @WhyNotHugo, loving this!

[WhyNotHugo]

Thanks. I'm currently using trouble.nvim for two things:

1. Diagnostics for current file.
2. Find all references (via LSP as well).

I'm trying to figure out a way to use compact for the former, but not for the latter. Not sure how it can happen, I think I need to add a second param to :Trouble.

[folke]

Hi! Thank you for this PR. Sorry for the delay, but I'm traveling right now. I'll be back next week.

I have plans to allow custom grouping and also to disable grouping (which is basically what you added).

Would be great to change your pr to allow the following settings instead:

• padding: defaults to 1. Can be set to 0 to disable as in your pr
• group: defaults to true (will add other options like severity etc later.) Can be false to disable groups and simply list the results as in your pr.

Do you think this makes sense?

[folke]

@WhyNotHugo you can already pass options to Trouble. Either to the command with option=value, or by using the Lua api

[WhyNotHugo]

I think your approach makes a lot more sense. It's tidier, can do the same thing, and is a bit more flexible.

you can already pass options to Trouble. Either to the command with option=value, or by using the Lua api

Those aren't the options that get passed to renderer.render, are they?

If I wanted two mappings that open Trouble, one with padding=0 and another with padding=1, is this the right way to start? I'm not sure where to hold this value or pass it one.

[WhyNotHugo]

Updated to implement group and padding.

I also noticed that :TroubleToggle wasn't passing opt to Trouble.toggle, but :Trouble does pass opts to Trouble.open. I've made this to now be consistent via 8a8cb37. Lemme know if that makes sense to you too.

[WhyNotHugo]

Hint: git diff -w(hide whitespace changes) is easier to read in this case.

[WhyNotHugo]

Do you have any further feedback on this?

I've done some testing with TroubleOpen lsp_document_diagnostics group=false and TroubleOpen lsp_document_diagnostics, and both work as intended. The config value is used when nothing is explicitly passed.

[folke]

Thank you!