-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1gg
hangs neovim
#118
Comments
I'm not able to reproduce this. Can you make a minimal config to trigger this? |
Found the offending keybinding: if !filereadable('/tmp/plug.vim')
silent !curl --insecure -fLo /tmp/plug.vim
\ https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
endif
source /tmp/plug.vim
call plug#begin('/tmp/plugged')
Plug 'folke/which-key.nvim'
call plug#end()
autocmd VimEnter * PlugClean! | PlugUpdate --sync | close
lua << EOF
require("which-key").setup{}
EOF
" https://github.com/neovim/neovim/blob/5d6ecfa3c7447009da75842c611ea1b9f1db83e7/runtime/doc/lsp.txt#L50
nnoremap <silent> 1gD <cmd>lua vim.lsp.buf.type_definition()<CR>
|
That's a really odd key binding. Not sure what that one was chosen to be put in the docs. Either way, I'll see if I can fix this properly. |
I think that's actually a typo in the LSP docs 😅 A better set of default bindings can be found on the lspconfig readme |
Can you check wether it even works with that binding without WhichKey? |
I think it's mimicking a built-in vim mapping I can solve it for me by removing it from my config (since I'm not using this particular mapping anyway), but IMO which-key shouldn't hang if a weird but valid mapping is present. |
I just pushed a fix for this. Thank you for reporting! |
Thanks! |
More generally, it seems that two-letter commands starting with
1
hang neovim (e.g.,1gg
,10dd
). But, e.g.,9dd
and10}
work fine.Probably related to #17.
The text was updated successfully, but these errors were encountered: