From c8ad8b9e19bda084a5f7a51e65143388bab35e3f Mon Sep 17 00:00:00 2001 From: Marco 'Lubber' Wienkoop Date: Fri, 31 Jul 2020 22:50:11 +0200 Subject: [PATCH] fix(sidebar): avoid scrollbar on non body pushable When a bottom sidebar was used inside non body pushable context, it was always added to the context divs height, making the vertical scrollbar appear. As the body will still provide a possible scrollbar it's save to remove the inner pushable vertical scrollbar. Reason for the behavior is the 100% translate3d() setting to hide the sidebar which adds its content to the parent div. For left/right the overflow-x:hidden is already set and for top it's a negative position of -100%, so the change of overflow-y is not affected in the other cases. --- src/definitions/modules/sidebar.less | 1 + 1 file changed, 1 insertion(+) diff --git a/src/definitions/modules/sidebar.less b/src/definitions/modules/sidebar.less index 33010d0d7f..54e1400741 100755 --- a/src/definitions/modules/sidebar.less +++ b/src/definitions/modules/sidebar.less @@ -112,6 +112,7 @@ body.pushable { /* Page Context */ .pushable:not(body) { transform: translate3d(0, 0, 0); + overflow-y: hidden; } .pushable:not(body) > .ui.sidebar, .pushable:not(body) > .fixed,