Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown] Setup select does not convert data-text to Menu items #1103

Closed
ronnievdc opened this issue Oct 17, 2019 · 3 comments
Closed

[Dropdown] Setup select does not convert data-text to Menu items #1103

ronnievdc opened this issue Oct 17, 2019 · 3 comments
Assignees
@prudho
Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements

Comments

@ronnievdc
Copy link

Feature Request

Description

When converting select dropdowns to dropdown menus with $('select').dropdown() the data-text metadata is not copied over to the menu dropdown.

Having this feature makes it possible to create select with optgroups, where the visible chosen value as label also contains the optgroup label.

Example

Testcase

https://jsfiddle.net/6hdtzybr/
@lubber-de lubber-de added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript labels Oct 17, 2019
@prudho prudho self-assigned this Dec 13, 2019
@prudho prudho mentioned this issue Dec 13, 2019
Merged
@prudho prudho added the state/has-pr An issue which has a related PR open label Dec 13, 2019
@prudho
Copy link
Contributor

prudho commented Dec 13, 2019

It should be delivered in 2.8.3 release. Related PR: #1219

@dutrieux
Copy link
Contributor

Nice feature !

@ronnievdc
Copy link
Author

Thanks for adding this feature!

@lubber-de lubber-de added tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build and removed state/has-pr An issue which has a related PR open labels Dec 22, 2019
@y0hami y0hami closed this as completed in a0a537b Dec 23, 2019
@y0hami y0hami removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudho prudho

Labels
lang/javascript Anything involving JavaScript type/feat Any feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dutrieux @prudho @y0hami @ronnievdc @lubber-de