Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint codebase with pyre? #3014

Closed
davelab6 opened this issue Aug 7, 2020 · 2 comments
Closed

Lint codebase with pyre? #3014

davelab6 opened this issue Aug 7, 2020 · 2 comments

Comments

@davelab6
Copy link
Contributor

davelab6 commented Aug 7, 2020

https://github.com/facebook/pyre-check/ might be helpful to catch some bugs
@graphicore
Copy link
Collaborator

graphicore commented Aug 9, 2020 •
edited
Loading

I agree, but we'd have to use type hints for this, otherwise there's nothing to check. I think the default, not hinted type, is always any. I used type hints (checked with mypy) in gftools packager it's definitely helpful, especially when the linter runs in the editor and one gets direct feedback.

@simoncozens
Copy link
Collaborator

Duplicate(ish) of #1824.

@simoncozens simoncozens closed this as not planned Won't fix, can't repro, duplicate, stale Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simoncozens @davelab6 @graphicore