Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check: GF central repo static files should not have extras, should be a 'full house' #3031

Open
davelab6 opened this issue Sep 9, 2020 · 1 comment
Assignees
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P2 Important Severity 4

Comments

@davelab6
Copy link
Contributor

davelab6 commented Sep 9, 2020

Observed behaviour

In google/fonts#2644 (comment) I noted there were some 'extra' files in the static directory, that were not corresponding to the files listed in the METADATA file for the family.

Expected behaviour

I propose to add check a GF profile check on the "downstream" GF central repo folders: They should not have extra files, and when a VF is used, if there are statics, they should exist for every 100 stop along the Weight axis. Eg, a Weight axis of 400 to 700 should have statics for 400, 500, 600 and 700 if any statics exist.

@felipesanches
Copy link
Collaborator

thanks, @davelab6

@felipesanches felipesanches modified the milestones: 0.7.38, 0.7.39 Jun 23, 2021
@felipesanches felipesanches modified the milestones: 0.7.39, 0.8.0 Jul 14, 2021
@felipesanches felipesanches modified the milestones: 0.8.0, 0.8.1 Jul 21, 2021
@felipesanches felipesanches modified the milestones: 0.8.1, 0.8.5 Aug 12, 2021
@felipesanches felipesanches modified the milestones: 0.8.5, 0.8.7 Dec 15, 2021
@felipesanches felipesanches modified the milestones: 0.8.7, 0.8.8 Feb 18, 2022
@felipesanches felipesanches modified the milestones: 0.8.8, 0.8.12 Mar 14, 2022
@felipesanches felipesanches modified the milestones: 0.8.12, 0.8.13 Aug 19, 2022
@felipesanches felipesanches modified the milestones: 0.8.13, 0.8.14 Jun 2, 2023
@felipesanches felipesanches removed this from the 0.9.0 milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id P2 Important Severity 4
Projects
None yet
Development

No branches or pull requests

3 participants