Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Fix in fork pending PR] Init script calls LSB function before including LSB functions #1653

Closed
tullo-x86 opened this issue Dec 14, 2016 · 2 comments
Labels
bug Issue describes a bug done Done but not yet released
Milestone

Comments

@tullo-x86
Copy link
Contributor

tullo-x86 commented Dec 14, 2016

Reprodutcion steps:

  • On a BeagleBone Black, boot from the Debian 8.6 IoT image dated 2016-12-09.
  • Login as "root", then
    adduser fab
    adduser fab tty
    adduser fab sudo
  • Logout, then login as "fab"
  • Clone OctoPrint from git
  • Enter OctoPrint's directory and sudo python setup.py install
  • Edit ~/OctoPrint/scripts/octoprint.default so that the user is "fab" instead of "pi"
  • Set OctoPrint to start on boot:
    cd ~
    sudo cp OctoPrint/scripts/octoprint.init /etc/init.d/octoprint
    sudo chmod +x /etc/init.d/octoprint
    sudo cp OctoPrint/scripts/octoprint.default /etc/default/octoprint
    sudo update-rc.d octoprint defaults
  • Try to start the service with sudo service octoprint start
  • When nothing happens, check the status with sudo service octoprint status
  • Note the reference to Line 31 stating that "log_warning_msg" could not be found

Expected behaviour

The init.d script should successfully start OctoPrint.

What happened instead?

The init.d script barfed because it couldn't figure out how to call "log_warning_msg" (because the line which includes it is below the call).

Branch & Commit or Version of OctoPrint

1.3.0 tag


Yes, I have read the FAQ.

@foosel foosel added done Done but not yet released bug Issue describes a bug labels Dec 14, 2016
@foosel foosel added this to the 1.3.1 milestone Dec 14, 2016
@foosel
Copy link
Member

foosel commented Dec 14, 2016

Thanks for the PR, merged on both maintenance and devel. Will be part of the 1.3.1 release.

@foosel
Copy link
Member

foosel commented Jan 25, 2017

Part of 1.3.1 which has just been released.

@foosel foosel closed this as completed Jan 25, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue describes a bug done Done but not yet released
Projects
None yet
Development

No branches or pull requests

2 participants