fix: do not write jsconfig.json on core when there is tsconfig.json #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @rui-rayqiu is an internal user so signing the CLA is not required. However, we need to confirm this. |
CristiCanizales
added
the
type:community-contrib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since we started to support TypeScript for LWC on core, we added
tsconfig.jsonfiles on core's UI modules directory, e.g.,ui-force-components/tsconfig.json. Thistsconfig.jsonwould conflict withjsconfig.jsonfile that is automatically generated. This PR disable the generation ofjsconfig.jsonfile on core if there is an existingjsconfig.jsonfile on core.What issues does this PR fix or reference?
@W-14590716@
Functionality before
current.mov
Functionality after
new.mov