Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: valid js config file #597

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: valid js config file #597

merged 1 commit into from
Aug 29, 2024

Conversation

CristiCanizales
Copy link
Contributor

What does this PR do?

  • Moves paths property to the right place in jsconfig.json, inside compilerOptions

What issues does this PR fix or reference?

@W-15374337@

@CristiCanizales CristiCanizales self-assigned this Aug 29, 2024
@CristiCanizales CristiCanizales requested a review from a team as a code owner August 29, 2024 19:19
@CristiCanizales CristiCanizales linked an issue Aug 29, 2024 that may be closed by this pull request
jsconfig.json generates incorrectly and disallows correction forcedotcom/salesforcedx-vscode#5520
Closed
@CristiCanizales CristiCanizales merged commit e53b96b into main Aug 29, 2024
8 checks passed
@CristiCanizales CristiCanizales deleted the cristi/fix-jsconfig branch August 29, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daphne-sfdc daphne-sfdc daphne-sfdc approved these changes

@peternhale peternhale peternhale approved these changes

@gbockus-sf gbockus-sf Awaiting requested review from gbockus-sf gbockus-sf is a code owner automatically assigned from forcedotcom/ide-experience

Assignees

@CristiCanizales CristiCanizales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsconfig.json generates incorrectly and disallows correction
3 participants
@CristiCanizales @peternhale @daphne-sfdc