Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle test method covering multiple classes #122

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

AnanyaJha
Copy link
Contributor

@AnanyaJha AnanyaJha commented Jan 14, 2021

What does this PR do?

This PR fixes an issue where we were reporting incomplete data when a test method covered multiple classes. We've updated the detailed coverage table to include a row for each class covered by each test instead of just having a single row for each test method. Now, we also report all covered classes when a single test method is run instead of just the last class.

What issues does this PR fix or reference?

@W-8674084@

Functionality Before

Screen Shot 2021-01-14 at 5 18 03 PM

Functionality After

Screen Shot 2021-01-14 at 5 15 50 PM

@AnanyaJha AnanyaJha requested a review from a team as a code owner January 14, 2021 23:19
@AnanyaJha AnanyaJha requested a review from brpowell January 14, 2021 23:21
coveredClassName: perClassCov.apexClassOrTriggerName,
outcome: elem.outcome,
coveredClassPercentage: perClassCov.percentage,
msg: elem.message ? elem.message : '',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try out the handy null coalescing feature in TS 3.7 here - elem.message ?? ''

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh fancy!

@AnanyaJha AnanyaJha merged commit 6cc3018 into develop Jan 19, 2021
@AnanyaJha AnanyaJha deleted the aj/perTestCov branch January 19, 2021 20:50
jag-j pushed a commit that referenced this pull request Jan 21, 2021
jag-j pushed a commit that referenced this pull request Jan 21, 2021
klewis-sfdc pushed a commit that referenced this pull request Oct 24, 2022
WillieRuemmele pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants