-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle test method covering multiple classes #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brpowell
reviewed
Jan 19, 2021
coveredClassName: perClassCov.apexClassOrTriggerName, | ||
outcome: elem.outcome, | ||
coveredClassPercentage: perClassCov.percentage, | ||
msg: elem.message ? elem.message : '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try out the handy null coalescing feature in TS 3.7 here - elem.message ?? ''
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh fancy!
AnanyaJha
commented
Jan 19, 2021
brpowell
approved these changes
Jan 19, 2021
jag-j
pushed a commit
that referenced
this pull request
Jan 21, 2021
jag-j
pushed a commit
that referenced
this pull request
Jan 21, 2021
klewis-sfdc
pushed a commit
that referenced
this pull request
Oct 24, 2022
WillieRuemmele
pushed a commit
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where we were reporting incomplete data when a test method covered multiple classes. We've updated the detailed coverage table to include a row for each class covered by each test instead of just having a single row for each test method. Now, we also report all covered classes when a single test method is run instead of just the last class.
What issues does this PR fix or reference?
@W-8674084@
Functionality Before
Functionality After