fix: add caret to command and fix tests #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-11385241@
mdonnalley
reviewed
Jul 6, 2022
| @@ -30,7 +30,7 @@ describe('Apex Execute Tests', async () => { | |||
| beforeEach(async () => { | |||
| sandboxStub = createSandbox(); | |||
|
|
|||
| $$.setConfigStubContents('GlobalInfo', { | |||
| $$.setConfigStubContents('AuthInfoConfig', { | |||
There was a problem hiding this comment.
You can remove all of these. This is essentially what $$.stubAuths() is doing for you
gbockus-sf
commented
Jul 6, 2022
| authInfo: await AuthInfo.create({ | ||
| username: testData.username | ||
| }) | ||
| }); |
There was a problem hiding this comment.
Two removed parts covered by stubAuths
mdonnalley
approved these changes
Jul 6, 2022
randi274
approved these changes
Jul 6, 2022
klewis-sfdc
pushed a commit
that referenced
this pull request
Oct 24, 2022
* fix: add caret to command and fix tests @W-11385241@ * chore: remove unnecessary stub from tests. update yarn.lock
WillieRuemmele
pushed a commit
that referenced
this pull request
Jan 31, 2023
* fix: add caret to command and fix tests @W-11385241@ * chore: remove unnecessary stub from tests. update yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
unpin
@salesforce/commandand fix tests. Note that pinning the module caused issues for cli b/c it results in long imports that break the circleci build.What issues does this PR fix or reference?
@W-11385241@