fix: remove listing git tags in deploy #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbockus-sf
commented
Sep 14, 2022
| @@ -91,9 +91,6 @@ commands: | |||
| create-git-tag: | |||
| steps: | |||
| - run: *gh-config | |||
| - run: | |||
| name: Current git tags | |||
| command: git tag | |||
There was a problem hiding this comment.
Same fix as in the templates repo. Basically this command hangs due to the number of tags being displayed. Just remove it.
randi274
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove listing git tags from the deploy step of the build to avoid failing due to waiting for user input.
What issues does this PR fix or reference?
fix #299
Functionality Before
deploy time out
Functionality After
deploy success