Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer ISO date format #334

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: prefer ISO date format #334

merged 1 commit into from
Nov 10, 2023

Conversation

shetzel
Copy link
Collaborator

@shetzel shetzel commented Nov 10, 2023

What does this PR do?

Changes test results start time to be ISO format. The JUnit reporter still reports the start time property in the locale format. The formatStartTime date utility also has the same default behavior but now also accepts an additional parameter for a date format (ISO or locale).

What issues does this PR fix or reference?

@W-10226817@
forcedotcom/cli#2220

Functionality Before

When a language format other than en_US was used to get the ISO time string from a locale specific time string an error would be thrown.

Functionality After

No error is thrown. JUnit test start time is still reported in the user locale. Test results JSON have the start time in ISO format.

@WillieRuemmele
Copy link
Member

QA Notes


✅ : LANG=en_CA.UTF-8 ../../oss/plugin-apex/bin/dev apex:run:test --output-dir test -w 10 -> same output as successful run
✅ : --json output
✅ : with changes, without the env var
✅ : --result-format -> would throw an error before printing, so new time format isn't breaking
✅ : no diffs between junit output
✅ : new NUT passes with library linked
✅ : NUT fails when unlinked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants