fix: dangling commas in json results #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-15471840@
daphne-sfdc
requested changes
Apr 12, 2024
There was a problem hiding this comment.
Thank you Pete for fixing this dangling commas issue!
I was able to confirm that there are no more dangling commas in the test-result.json file that is generated after Apex tests are run, and the code coverage highlighting is working again.
QE doc here: https://salesforce.quip.com/4LbOAXV06fbm ✅
Just some nits and then this is ready to be merged.
Co-authored-by: Daphne Yang <139700604+daphne-sfdc@users.noreply.github.com>
daphne-sfdc
approved these changes
Apr 12, 2024
gilgourevitch
pushed a commit
to gilgourevitch/salesforcedx-apex
that referenced
this pull request
Jun 6, 2024
* fix: dngling commas in json results @W-15471840@ * Update test/streaming/testResultStringifyStream.test.ts Co-authored-by: Daphne Yang <139700604+daphne-sfdc@users.noreply.github.com> * chore: update tests date to cover per class coverage transform --------- Co-authored-by: Daphne Yang <139700604+daphne-sfdc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes a bug that was introduced when making the change to streams for output generation
What issues does this PR fix or reference?
@W-15471840@
#5534
Functionality Before
unneeded commas were being inserted into json results
Functionality After
Unneeded commas removed