Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change how oclif manifest gets generated #88

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Nov 5, 2020

What does this PR do?

This PR changes the way we generate the oclif manifest to be a manual process (for now) since we want to remove the references to apex:test:run.

Without these changes, we get the following error when installing the plugin

Error: Cannot find module '/Users/username/.local/share/sfdx/node_modules/@salesforce/plugin-apex/lib/commands/force/apex/test/run'

What issues does this PR fix or reference?

@W-8340748@

@lcampos lcampos requested a review from a team as a code owner November 5, 2020 18:52
@@ -0,0 +1,191 @@
{
"version": "0.1.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually set this to the next version so we don't get this error after installing the plugin

(node:72248) Warning: Mismatched version in @salesforce/plugin-apex plugin manifest. Expected: 0.1.4 Received: 0.1.3
This usually means you have an oclif.manifest.json file that should be deleted in development. This file should be automatically generated when publishing.

@lcampos lcampos merged commit 9aac8ce into develop Nov 5, 2020
@lcampos lcampos deleted the lcampos/remove-test-run-from-oclifmanifest branch November 5, 2020 19:08
lcampos added a commit that referenced this pull request Nov 5, 2020
lcampos added a commit that referenced this pull request Nov 5, 2020
WillieRuemmele pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants