Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add junit result format to test:run command #96

Merged
merged 4 commits into from
Nov 19, 2020
Merged

Conversation

AnanyaJha
Copy link
Contributor

What does this PR do?

This PR adds the JUnit result format to the test:run command

What issues does this PR fix or reference?

@W-7561364@

@AnanyaJha AnanyaJha requested a review from a team as a code owner November 17, 2020 16:04
successResult
} from './testResults';

describe('JUnit Reporter Tests', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test case where the data also has code coverage info

// header
let JUNIT_TEMPLATE = `<?xml version="1.0" encoding="UTF-8"?>\n`;
JUNIT_TEMPLATE += `<testsuites>\n`;
JUNIT_TEMPLATE += ` <testsuite name="force.apex" `;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use \t or a variable that represents the spacing ? The current pattern seems easy to accidentally break without clearly noticing it on a code review/diff.

@AnanyaJha AnanyaJha merged commit e95991b into develop Nov 19, 2020
@AnanyaJha AnanyaJha deleted the aj/junit branch November 19, 2020 20:29
sfsholden pushed a commit that referenced this pull request Nov 20, 2020
sfsholden pushed a commit that referenced this pull request Nov 20, 2020
klewis-sfdc pushed a commit that referenced this pull request Oct 24, 2022
WillieRuemmele pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants