fix: use default options off the constructor

also update all the incorrect docs for AsyncCreatable

examples/examples/aliasEditor/aliasEditor.ts

@@ -10,7 +10,7 @@ export async function run() {
 
   const orgs = authFiles.map(authfile => authfile.replace('.json', ''));
   const orgsWithAliases = {};
-  const aliases = await Aliases.create();
+  const aliases = await Aliases.create({});
 
   // Map the aliases onto the orgs
   for (const org of orgs) {
@@ -19,9 +19,7 @@ export async function run() {
   }
 
   // Buffer length for displaying to the user
-  const len =
-    (_.max(_.map(_.values(orgsWithAliases), element => element || 0)) as string)
-      .length + 4;
+  const len = (_.max(_.map(_.values(orgsWithAliases), element => element || 0)) as string).length + 4;
 
   // Have the user select a user to add or remove alias
   const answer = await select(
@@ -43,9 +41,7 @@ export async function run() {
   const [alias, username] = strip(answer).split(/\s*: /);
 
   // Enter a new alias
-  const { newAlias } = await inquirer.prompt([
-    { name: 'newAlias', message: 'Enter a new alias (empty to remove):' }
-  ]);
+  const { newAlias } = await inquirer.prompt([{ name: 'newAlias', message: 'Enter a new alias (empty to remove):' }]);
 
   if (alias !== 'N/A') {
     // Remove the old one
@@ -55,9 +51,7 @@ export async function run() {
 
   if (newAlias) {
     aliases.set(newAlias, username);
-    console.log(
-      `Set alias ${chalk.green(newAlias)} to username ${chalk.green(username)}`
-    );
+    console.log(`Set alias ${chalk.green(newAlias)} to username ${chalk.green(username)}`);
   }
   await aliases.write();
 }

examples/examples/apexLogStream/apexLogStream.ts

@@ -1,43 +1,27 @@
-import {
-  AuthInfo,
-  DefaultStreamingOptions,
-  Org,
-  StatusResult,
-  StreamingClient,
-  StreamingOptions
-} from '@salesforce/core';
+import { AuthInfo, Org, StatusResult, StreamingClient } from '@salesforce/core';
 import { JsonMap } from '@salesforce/ts-types';
 import chalk from 'chalk';
 import * as inquirer from 'inquirer';
 
 let org: Org;
 
 export async function run() {
-  function streamProcessor(message: JsonMap): StatusResult<string> {
-    console.log(
-      chalk.blue('Apex Log Found:'),
-      chalk.green(message.sobject['Id'])
-    );
-    console.log(
-      org
-        .getConnection()
-        .request(`/sobjects/ApexLog/${message.sobject['Id']}/Body`)
-    );
+  function streamProcessor(message: JsonMap): StatusResult {
+    console.log(chalk.blue('Apex Log Found:'), chalk.green(message.sobject['Id']));
+    console.log(org.getConnection().request(`/sobjects/ApexLog/${message.sobject['Id']}/Body`));
     // Listen forever to get all the logs until the stream timesout
     return { completed: false };
   }
 
   async function startStream(username) {
     org = await Org.create(username);
-    const options: StreamingOptions<string> = new DefaultStreamingOptions(
+    const options: StreamingClient.Options = new StreamingClient.DefaultOptions(
       org,
       '/systemTopic/Logging',
       streamProcessor
     );
 
-    const asyncStatusClient: StreamingClient<
-      string
-    > = await StreamingClient.init(options);
+    const asyncStatusClient = await StreamingClient.create(options);
 
     await asyncStatusClient.handshake();
     console.log('Handshaked!');

examples/examples/apiExplorer/apiExplorer.ts

@@ -16,7 +16,7 @@ export async function run() {
 
   // Connect to the user
   const authInfo = await AuthInfo.create(connectionOrg);
-  const connection = await Connection.create(authInfo);
+  const connection = await Connection.create({ authInfo });
 
   console.log('Connected!\n');
 
@@ -28,9 +28,7 @@ export async function run() {
   // noinspection InfiniteLoopJS
   while (true) {
     try {
-      response = await connection.request(
-        await select('Select endpoint', options)
-      );
+      response = await connection.request(await select('Select endpoint', options));
       console.log('\n', chalk.green(JSON.stringify(response, null, 4)), '\n');
 
       // Only change the options if they are urls

examples/examples/test/mocha.opts

@@ -0,0 +1,6 @@
+--require ts-node/register
+--require source-map-support/register
+--watch-extensions ts
+--recursive
+--reporter spec
+--timeout 5000

examples/examples/test/unit/MockAuthInfoTest.ts

@@ -1,6 +1,6 @@
-import { strictEqual } from 'assert';
-import { MockTestOrgData, testSetup } from '@salesforce/core/lib/testSetup';
 import { AuthInfo } from '@salesforce/core';
+import { MockTestOrgData, testSetup } from '@salesforce/core/lib/testSetup';
+import { strictEqual } from 'assert';
 
 const $$ = testSetup();
 
@@ -10,7 +10,9 @@ describe('Mocking Auth data', () => {
     $$.setConfigStubContents('AuthInfoConfig', {
       contents: await testData.getConfig()
     });
-    const auth: AuthInfo = await AuthInfo.create(testData.username);
+    const auth: AuthInfo = await AuthInfo.create({
+      username: testData.username
+    });
     strictEqual(auth.getUsername(), testData.username);
   });
 });

examples/examples/test/unit/MockConnectionTest.ts

@@ -10,9 +10,11 @@ describe('Mocking an SFDX connection', () => {
     $$.setConfigStubContents('AuthInfoConfig', {
       contents: await testData.getConfig()
     });
-    const connection: Connection = await Connection.create(
-      await AuthInfo.create(testData.username)
-    );
+    const connection: Connection = await Connection.create({
+      authInfo: await AuthInfo.create({
+        username: testData.username
+      })
+    });
     strictEqual(connection.accessToken, testData.accessToken);
   });
 });

examples/examples/test/unit/MockServerRequest.ts

@@ -19,17 +19,13 @@ describe('Mocking a force server call', () => {
       if (request && ensureString(_request.url).includes('Account')) {
         return Promise.resolve(records);
       } else {
-        return Promise.reject(
-          new SfdxError(`Unexpected request: ${_request.url}`)
-        );
+        return Promise.reject(new SfdxError(`Unexpected request: ${_request.url}`));
       }
     };
-    const connection: Connection = await Connection.create(
-      await AuthInfo.create(testData.username)
-    );
-    const result: QueryResult<{}> = await connection.query(
-      'select Id From Account'
-    );
+    const connection: Connection = await Connection.create({
+      authInfo: await AuthInfo.create({ username: testData.username })
+    });
+    const result: QueryResult<{}> = await connection.query('select Id From Account');
     deepStrictEqual(result, records);
   });
 });

examples/examples/test/unit/TestSandbox.ts

@@ -1,6 +1,6 @@
-import { strictEqual } from 'assert';
 import { testSetup } from '@salesforce/core/lib/testSetup';
 import { stubMethod } from '@salesforce/ts-sinon';
+import { strictEqual } from 'assert';
 import * as os from 'os';
 
 const $$ = testSetup();

examples/package.json

@@ -4,24 +4,26 @@
   "description": "Examples using the SFDX Core libraries to interact with SFDX projects, orgs, and APIs.",
   "main": "index.js",
   "license": "BSD-3-Clause",
-  "scripts": {},
+  "scripts": {
+    "test": "mocha examples/test/unit/** --opts examples/test/mocha.opts"
+  },
   "keywords": [
     "sfdx",
     "sfdx-core",
     "Salesforce DX",
     "Salesforce CLI"
   ],
   "dependencies": {
-    "@salesforce/core": "^0.23.3",
+    "@salesforce/core": "^1",
     "chalk": "^2.4.1",
     "inquirer": "^6.0.0",
     "lodash": "^4.17.10",
-    "strip-ansi": "^4.0.0",
-    "@salesforce/ts-types": "0.14.0"
+    "strip-ansi": "^4.0.0"
   },
   "devDependencies": {
-    "@salesforce/dev-config": "^1.1.2",
-    "@salesforce/ts-sinon": "^0.2.2",
+    "@salesforce/ts-types": "^1",
+    "@salesforce/dev-config": "^1.4.4",
+    "@salesforce/ts-sinon": "^1",
     "@types/lodash": "^4.14.104",
     "@types/node": "^9.4.7",
     "@types/mocha": "^5.2.5",