Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refresh a project #1128

Merged
merged 1 commit into from
Aug 13, 2024
Merged

feat: refresh a project #1128

merged 1 commit into from
Aug 13, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

clearInstance on SfProject

why no tests?

  • I can't use UT with testSetup because there isn't a real project.
  • I don't want to pull in testkit and do a NUT to avoid a circular dependency

What issues does this PR fix or reference?

needed for @W-16486531@

@mshanemc mshanemc requested a review from a team as a code owner August 13, 2024 17:42
@mshanemc mshanemc merged commit 56a93bb into main Aug 13, 2024
74 of 75 checks passed
@mshanemc mshanemc deleted the sm/refresh-sfProjectJson branch August 13, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mshanemc @shetzel @svc-cli-bot