Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mdTypes from core export #1398

Merged
merged 14 commits into from
Aug 19, 2024
Merged

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

given that the file has been copied from the core test branch to SDR, add them to the registry

What issues does this PR fix or reference?

@W-16495885@

@mshanemc mshanemc marked this pull request as ready for review August 16, 2024 19:33
@mshanemc mshanemc requested a review from a team as a code owner August 16, 2024 19:33
@WillieRuemmele
Copy link
Member

QA Notes


❌ :

sf alias set registryBuilder=<my org>

# changed metadata registry entries, expecting next command to revert changes
 ➜  yarn update-registry-org CustomField ListView customnotificationtype
yarn run v1.22.22
$ npx ts-node scripts/update-registry/updateRegistryFromOrg.ts CustomField ListView customnotificationtype
Will get describe for these types:
 - CustomField
 - ListView
 - customnotificationtype
[]
✨  Done in 2.85s.


# no changes to file

❌ : from the contributing/metadata.md => Running the script with no params will try to do ALL missing metadata types. =>

 ➜  yarn update-registry-org                                            
yarn run v1.22.22
$ npx ts-node scripts/update-registry/updateRegistryFromOrg.ts
/Users/william.ruemmele/projects/oss/source-deploy-retrieve/scripts/update-registry/updateRegistryFromOrg.ts:38
})();
  ^
Error: Please provide the types to update the registry with.  Ex: `yarn update-registry-org CustomObject CustomField`
    at /Users/william.ruemmele/projects/oss/source-deploy-retrieve/scripts/update-registry/updateRegistryFromOrg.ts:29:11

@mshanemc
Copy link
Contributor Author

yarn update-registry-org CustomField ListView customnotificationtype

fyi, customnotificationtype will work with the next change. CustomField and ListView aren't in the describe because they're not top-level types but are children of CustomObject.

@mshanemc
Copy link
Contributor Author

Running the script with no params will try to do ALL missing metadata types

Ooh, good docs catch. I meant to disable that option for the org version because there's such a low chance of success

@WillieRuemmele
Copy link
Member

yarn update-registry-org CustomField ListView customnotificationtype

fyi, customnotificationtype will work with the next change. CustomField and ListView aren't in the describe because they're not top-level types but are children of CustomObject.

figured out the CF/LV wouldn't work, and then happened to choose another type that wouldn't work... unlucky on my part. I'll try again

@WillieRuemmele
Copy link
Member

WillieRuemmele commented Aug 19, 2024

QA Notes


✅ : changed ApexClass entry, ran yarn update-registry-org ApexClass and it was updated, but it was missing supportsWildCardAndName field
✅ : same, yarn update-registry-org apexclass
✅ : will add missing type
✅ : must pass types to script
✅ : warning message for child types

✅ : yarn update-registry-core will update types - supportsWildCardAndName missing as well, could require manual intervention - if it's possible to detect this, we should warn the user
✅ : yarn update-registry-core will add missing types
✅ : yarn update-registry-core ApexClass
✅ : yarn update-registry-core apexclass
✅ : warning message for child types

@WillieRuemmele WillieRuemmele merged commit d1e6357 into main Aug 19, 2024
74 checks passed
@WillieRuemmele WillieRuemmele deleted the sm/registry-from-internal-describe branch August 19, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants