Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to 1.0 #33

Closed
5 tasks done
foresterre opened this issue Jun 3, 2020 · 0 comments · Fixed by #59
Closed
5 tasks done

Path to 1.0 #33

foresterre opened this issue Jun 3, 2020 · 0 comments · Fixed by #59
Labels

Comments

@foresterre
Copy link
Owner

foresterre commented Jun 3, 2020

checklist for stabilization

Potential concerns per API level

High level
The queue is managed

  • (HL1, #?) Should we rescale the queue for each element, or perhaps resize it by powers of two (how would we do the prediction)? (This would not necessary change the API, thus could be a determined after a stable release)
  • ...

Low level
You are able to manage the queue yourself

library management

Questions

  • (Q1) Are we happy with the current API? Do we expect breaking changes? Do, and if so, what do we like to add? yes
  • (Q2) Is the terminology consistent?, after Improve the rustdoc documentation #54, yes
  • (Q3) Is everything properly tested?, To the best of my knowledge, yes. We could add fuzzing, but we keep that as a wishlist item.
  • (Q4) Is the documentation up-to-date? , after Improve the rustdoc documentation #54, yes
  • (Q5) Are there performance considerations which should be handled before stabilizing the API? (benchmark)
    • According to my first preliminary benchmarks, smallvec may not be a good fit as the default feature. I'm not sure if my benchmark is actually performed correctly, but disabling smallvec by default and keeping it as an option sounds like a safe choice.
    • This could be caused by having a too large stack size for smallvec; the docs recommend a small amount, an give 4 and 8 as example values. I'm not sure how small the amount should be.
    • Disabled by default in Disable smallvec by default #58, opt-in with --feature smallvec

List of actions

Planned time path

December 2020: Q1, Q5,
January 2021: Q2, Q3, Q4

1.0.0: February 2021

tagged open issues: M-v1.0.0

@foresterre foresterre changed the title Prepare 1.0.0 Prepare stable release 1.0.0 Jun 3, 2020
@foresterre foresterre pinned this issue Sep 4, 2020
@foresterre foresterre added the M-v1.0.0 Milestone: v1.0.0 label Sep 4, 2020
@foresterre foresterre changed the title Prepare stable release 1.0.0 Path to 1.0.0 release Sep 7, 2020
@foresterre foresterre changed the title Path to 1.0.0 release Path to 1.0 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant