[fix] Make column operations work

foreversd · Nov 23, 2011 · 58c251f · 58c251f
1 parent b9c5f18
commit 58c251f
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/lib/forever/cli.js b/lib/forever/cli.js
@@ -144,7 +144,7 @@ function updateConfig(updater) {
 // Checks if column `name` exists
 //
 function checkColumn(name) {
-  if (forever.columns[name]) {
+  if (!forever.columns[name]) {
     forever.log.error('Unknown column: ' + name.magenta);
     return false;
   }
@@ -397,12 +397,12 @@ app.cmd('columns add :name', cli.addColumn = function (name) {
   if (checkColumn(name)) {
     var columns = forever.config.get('columns');
 
-    if (~columns.indexOf(value)) {
-      return forever.log.warn(value.magenta + ' already exists in forever');
+    if (~columns.indexOf(name)) {
+      return forever.log.warn(name.magenta + ' already exists in forever');
     }
 
-    forever.log.info('Adding column: ' + value.magenta);
-    columns.push(value);
+    forever.log.info('Adding column: ' + name.magenta);
+    columns.push(name);
 
     forever.config.set('columns', columns);
     forever.config.saveSync();
@@ -413,21 +413,20 @@ app.cmd('columns rm :name', cli.rmColumn = function (name) {
   if (checkColumn(name)) {
     var columns = forever.config.get('columns');
 
-    if (!~columns.indexOf(value)) {
-      return forever.log.warn(value.magenta + ' doesn\'t exist in forever');
+    if (!~columns.indexOf(name)) {
+      return forever.log.warn(name.magenta + ' doesn\'t exist in forever');
     }
 
-    forever.log.info('Removing column: ' + value.magenta);
-    columns.splice(columns.indexOf(value), 1);
+    forever.log.info('Removing column: ' + name.magenta);
+    columns.splice(columns.indexOf(name), 1);
 
     forever.config.set('columns', columns);
     forever.config.saveSync();
   }
 });
 
-app.cmd('columns set :value', cli.setColumns = function (value) {
-  forever.log.info('Setting columns: ' + value.join(' ').magenta);
-  columns = value;
+app.cmd('columns set :value', cli.setColumns = function (columns) {
+  forever.log.info('Setting columns: ' + columns.join(' ').magenta);
 
   forever.config.set('columns', columns);
   forever.config.saveSync();