improved error handling

in fixing the one I missed, I noticed that it's procedure in this codebase to emit asynchronously.
foreversd · Oct 30, 2014 · eecf6a2 · eecf6a2
1 parent 6707a40
commit eecf6a2
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/lib/forever.js b/lib/forever.js
@@ -174,7 +174,13 @@ function stopOrRestart(action, event, format, target) {
     });
   }
 
-  getAllProcesses(function (processes) {
+  getAllProcesses(function (err, processes) {
+    if (err) {
+      return process.nextTick(function () {
+        emitter.emit('error', err);
+      });
+    }
+
     var procs = processes;
 
     if (target !== undefined && target !== null) {
@@ -732,8 +738,9 @@ forever.cleanUp = function (cleanLogs, allowManager) {
 
   getAllProcesses(function (err, processes) {
     if (err) {
-      emitter.emit('error', err);
-      return;
+      return process.nextTick(function () {
+        emitter.emit('error', err);
+      });
     }
     else if (cleanLogs) {
       forever.cleanLogsSync(processes);