Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: --skipIgnoreFile argument to silent error "Could not read .foreverignore file" #1024

Open
ww9 opened this issue Mar 14, 2019 · 4 comments

Comments

@ww9
Copy link

ww9 commented Mar 14, 2019

I couldn't find an argument to silent the error: Could not read .foreverignore file.

I'm using forever to restart a Node.js script whenever I press CTRL+S in the editor. This gives me quick feedback and it's awesome. However, I don't need the ignore file and I'd love to silent that error.

image

I've read #590 and it seems that this is considered a bug as @indexzero wrote:

There is a bug in forever-monitor because when .foreverignore doesn't exist it shouldn't error.

Since this has been the default behavior for so long, I'm afraid that simply silencing this error by default would cause more harm than good for developers and projects that expect it.

Perhaps forever could implement a --skipIgnoreFile parameter?

Thoughts?

@ww9 ww9 changed the title Suggestion: --noconfig argument to silent error "Could not read .foreverignore file" Suggestion: --skipIgnoreFile argument to silent error "Could not read .foreverignore file" Mar 14, 2019
@ww9
Copy link
Author

ww9 commented Mar 14, 2019

I edited the Issue to clarify that the argument should tell forever-monitor to skip trying to attempt to read the .foreverignore file, not config file.

I implemented the suggested changes in my machine and it works:
image

Would you be interested in a pull request?

@ww9
Copy link
Author

ww9 commented Mar 14, 2019

Nevermind, nodemon works for my usecase out of the box so I'm switching to that.

@ww9 ww9 closed this as completed Mar 14, 2019
@kibertoad
Copy link
Contributor

Pull request would be awesome, though, if you could push the code you wrote :)

@ww9
Copy link
Author

ww9 commented Mar 14, 2019

Sure why not. Let me reopen this.

Will close once PR is merged in both repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants