Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline only records navigations where destination route includes a loader? #78

Open
halljus opened this issue Dec 1, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@halljus
Copy link

halljus commented Dec 1, 2023

Not sure if this is intentional or a bug, but I've noticed the Timeline pane only seems to list navigations where the destination route includes a loader. I was expecting all navigations would show up, but perhaps this is by design?

@AlemTuzlak
Copy link
Contributor

@halljus So the timeline depends on the useNavigation hook and listens to changes, if the state does not go into loading (which happens when loaders are triggered) there is no event to record so this is a limitation. But this is something I'd like to add in the future for sure where I detect route changes and add them to the timeline

@AlemTuzlak AlemTuzlak added the good first issue Good for newcomers label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants