Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace toolchain.toml with rust-version in Cargo.toml #196

Closed
Sherlock-Holo opened this issue Dec 1, 2022 · 1 comment · Fixed by #197
Closed

replace toolchain.toml with rust-version in Cargo.toml #196

Sherlock-Holo opened this issue Dec 1, 2022 · 1 comment · Fixed by #197

Comments

@Sherlock-Holo
Copy link

rust-lang/cargo#8072 has supported rust-version in Cargo.toml, replace the toolchain.toml should avoid downloading old version toolchain when user have a new version toolchain, but also limit the newer api usage

@Sherlock-Holo
Copy link
Author

and the current stable version

rustc 1.65.0 (897e37553 2022-11-02)

can build the PR #195, however the toolchain.toml version report failed

error[E0658]: trait bounds other than Sized on const fn parameters are unstable
--> /home/sherlock/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/enum-iterator-1.1.3/src/lib.rs:82:26
|
82 | pub const fn cardinality<T: Sequence>() -> usize {
| ^
|
= note: see issue #93706 rust-lang/rust#93706 for more information

For more information about this error, try rustc --explain E0658.
error: could not compile enum-iterator due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

maybe git-trim can update the rust toolchain version to latest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant