Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure which labels are removed #7

Open
foriequal0 opened this issue Feb 4, 2021 · 2 comments
Open

Configure which labels are removed #7

foriequal0 opened this issue Feb 4, 2021 · 2 comments

Comments

@foriequal0
Copy link
Owner

Add annotations to the service like this pod-graceful-drain/patchLabels: removethis-,setthis=other
@ajaykumarmandapati
Copy link
Contributor

ajaykumarmandapati commented May 7, 2021 •
edited

Thanks for this brilliant work! @foriequal0 However we were wondering can this be achieved for the current release? i.e. we do not want to remove certain labels during the termination phase of the pod. Thanks!

@foriequal0
Copy link
Owner Author

foriequal0 commented May 10, 2021 •
edited

@ajaykumarmandapati Hi! I currently don't have a concrete plan to implement this, and I'm a little bit busy for now.
Also, such options have a lot of choice of implementation. I need more concrete use-cases since I want to make this controller simple as possible.
I think you could try to retain labels with an another mutating admission controller such as Kyverno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@foriequal0 @ajaykumarmandapati