Skip to content
This repository has been archived by the owner on Aug 10, 2021. It is now read-only.

aud not handling a string vs. #5

Closed
jaysonhurd opened this issue Oct 26, 2020 · 4 comments
Closed

aud not handling a string vs. #5

jaysonhurd opened this issue Oct 26, 2020 · 4 comments

Comments

@jaysonhurd
Copy link

https://tools.ietf.org/html/rfc7519#section-4.1.3

RFC above says this should support a string or an array of strings but currently it only supports an array of strings in this package.

The repo you forked from appears to have started this in an unreleased version here:

https://github.com/dgrijalva/jwt-go/blob/v4.0.0-preview1/claim_strings.go

We're running into an issue with Azure tokens not being able to validate because aud returns from it as just a string and not an array of strings. Before going on to fix this ourselves we thought to see if it's something you wanted to fix here rather than have another repo out there doing the same thing.

@Fenny
Copy link

Fenny commented Nov 13, 2020

@Waterdrips, @martinreus-form3 could we fix this on this fork?

@Waterdrips
Copy link

Waterdrips commented Nov 13, 2020

Hey, got an example payload?

Thought this was a test for a single string audience here:
https://github.com/form3tech-oss/jwt-go/blob/master/map_claims_test.go#L16-L26

@jaysonhurd
Copy link
Author

Thanks! We will test it out.

@joshua-hill-form3
Copy link

This fork is now archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants