Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligner for headless text fields/areas, similar to Button.Aligner #180

Closed
b-graves opened this issue Oct 5, 2023 · 3 comments
Closed

Aligner for headless text fields/areas, similar to Button.Aligner #180

b-graves opened this issue Oct 5, 2023 · 3 comments

Comments

@b-graves
Copy link

b-graves commented Oct 5, 2023

Is your feature request related to a problem? Please describe.

Headless text fields/area still have padding, so become misaligned from the text. See example:

Screenshot 2023-10-05 at 14 55 51

Describe the solution you'd like
Either no padding on headless options or an Aligner the same was we have for ghost Buttons

Describe alternatives you've considered
Manually changing the styling

@blvdmitry blvdmitry moved this to 2.5.0 in Reshaped Oct 10, 2023
@blvdmitry blvdmitry moved this from 2.5.0 to In Progress in Reshaped Oct 15, 2023
@blvdmitry
Copy link
Contributor

Ready for the next release for TextField and TextArea. I went with the Aligner approach to make sure DX is aligned with other components. To make sure there is not much additional overhead though, I've added a common internal aligner utility that works across mutliple component. Keeping it internal since there are dependencies on data-attributes and css variables to get the padding value instead of hardcoding them.

https://twitter.com/blvdmitry/status/1713653015742202316

Image

@github-project-automation github-project-automation bot moved this from In Progress to Waiting for the release in Reshaped Oct 15, 2023
@blvdmitry
Copy link
Contributor

One change I've added after the screenshot was made is to use alignment on all sides for inputs. That way View gaps will stay predictable since headless inputs padding is invisible on all sides

@b-graves
Copy link
Author

Love this, thanks so much!

@blvdmitry blvdmitry moved this from Waiting for the release to Recently completed in Reshaped Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants