Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal - Allow styling of Backdrop #229

Closed
alexandertrefz opened this issue Mar 18, 2024 · 3 comments
Closed

Modal - Allow styling of Backdrop #229

alexandertrefz opened this issue Mar 18, 2024 · 3 comments

Comments

@alexandertrefz
Copy link

alexandertrefz commented Mar 18, 2024

Describe the solution you'd like
I would like to lock the modal in place if a request is sent from it (If it is a confirmation for a CRUD API basically) while that request is in flight.
I can disable the cancel button and turn the confirm button to loading but the modal stays dismissible via the backdrop.

Additionally it would also be great if we could pass attributes (or just the className, really) to the backdrop, so we could style it. (I would like to slightly blur it, for example)

@blvdmitry
Copy link
Contributor

overlay classname: 👍

As for locking the dismissible action – won't it work already with the way Modal is set up? Since it's completely controlled – you're passing its onClose handler that controls when it gets closed. Is there something that prevents you from removing that handler by default and only change the modal state once the request was completed?

@alexandertrefz
Copy link
Author

Apologies! In my testing of various things I must have forgotten to remove the onClose handler. That works just like I was imagining. A slightly more explicit description of this in the Documentation might be helpful.

@alexandertrefz alexandertrefz changed the title Modal - Add Option to not dismiss via Backdrop Modal - Allow styling of Backdrop Mar 18, 2024
@blvdmitry blvdmitry moved this to 2.11.0 in Reshaped Mar 22, 2024
@blvdmitry blvdmitry moved this from 2.11.0 to In Progress in Reshaped Mar 22, 2024
@blvdmitry blvdmitry moved this from In Progress to 2.11.0 in Reshaped Mar 22, 2024
@blvdmitry blvdmitry moved this from 2.11.0 to In Progress in Reshaped Mar 24, 2024
@blvdmitry
Copy link
Contributor

<Modal overlayClassName={...} /> should be available in 2.10.9. Documentation deployment will follow in the upcoming minor release 🔥

@github-project-automation github-project-automation bot moved this from In Progress to Waiting for the release in Reshaped Mar 26, 2024
@blvdmitry blvdmitry moved this from Waiting for the release to Recently completed in Reshaped Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants