Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Minor improvements of the Vite installation guide #238

Closed
molefrog opened this issue Apr 5, 2024 · 2 comments
Closed

[Documentation] Minor improvements of the Vite installation guide #238

molefrog opened this issue Apr 5, 2024 · 2 comments

Comments

@molefrog
Copy link

molefrog commented Apr 5, 2024

First of all, Reshaped looks sick! Absolutely love its design and simplicity.

I've followed the Vite guide from the docs and there were some minor things I thought would be nice to have in the guide. It wasn't a big deal, but it could save up a couple of minutes for people who aren't familiar with Vite.

  1. It seems like Vite does not generate postcss.config.js by default, while the docs assume the file is already there.
  2. The code for App.tsx doesn't contain a default export so a simple copy-and-paste won't work. Adding an extra line to that snippet could slightly improve the experience.
@blvdmitry
Copy link
Contributor

Thanks for highlighting these, I'll update those bits in the Vite docs for the upcoming release 🙌

@blvdmitry blvdmitry moved this to 2.11.0 in Reshaped Apr 7, 2024
@blvdmitry blvdmitry moved this from 2.11.0 to In Progress in Reshaped Apr 9, 2024
@blvdmitry
Copy link
Contributor

Updated the content in the upcoming release planned for the next Monday

@github-project-automation github-project-automation bot moved this from In Progress to Waiting for the release in Reshaped Apr 9, 2024
@blvdmitry blvdmitry moved this from Waiting for the release to Recently completed in Reshaped Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently completed
Development

No branches or pull requests

2 participants