-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Modal's to scroll on mobile devices #242
Comments
Good point, I think it might be better to prevent swiping while scrolling is meant to happen first of all (can detect that based on the elements dimensions and scroll position). That should resolve the issue without opting-out manually with a prop |
Can you check if this works for you in 2.10.19? There already was partial handling of this use case which I forgot existed but it wasn't handling it correctly in some cases Area.mp4 |
@blvdmitry, works as expected now, thank you for a quick fix |
Is your feature request related to a problem? Please describe.
On mobile, user's can't scroll up inside a modal, It seems they are able to scroll down but scrolling back up will trigger the modals swipe to close.
Describe the solution you'd like
Not sure what will be the ideal solution, but one thing that comes to mind is a prop to opt-out?
Describe alternatives you've considered
Might add an onMove
event.stopPropagation()
on my overflow container to temp prevent this behaviorexample: Mobile devices currently can't scroll up, it closes the modal instead
Screen.Recording.2024-04-11.at.11.43.22.PM.mov
The text was updated successfully, but these errors were encountered: