feat: optimize ledgerv1 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyrag
force-pushed
the
feat/some-opti
branch
2 times, most recently
from
2a94901
to
adb0cf4
Compare
Codecov Report
@@ Coverage Diff @@
## release/v1.10 #453 +/- ##
=================================================
- Coverage 64.06% 64.05% -0.01%
=================================================
Files 152 152
Lines 14032 14142 +110
=================================================
+ Hits 8989 9059 +70
- Misses 4460 4490 +30
- Partials 583 593 +10
|
| if err := l.store.Close(ctx); err != nil { | ||
| return errors.Wrap(err, "closing store") | ||
| } | ||
| //if err := l.store.Close(ctx); err != nil { |
There was a problem hiding this comment.
Should we keep the store close ?
There was a problem hiding this comment.
Oh, i've forgot to close! thks
| return &Store{ | ||
| executorProvider: executorProvider, | ||
| schema: schema, | ||
| onClose: onClose, | ||
| onDelete: onDelete, | ||
| bloom: bloom.NewWithEstimates(1000000, 0.01), // TODO: Configure |
There was a problem hiding this comment.
Do you want to make that configurable ?
|
|
||
| entry, ok := s.cache.Get(address) | ||
| if ok { | ||
| account := entry.(*core.AccountWithVolumes) |
pkg/storage/sqlstorage/volumes.go
Outdated
|
|
||
| entry, ok := s.cache.Get(address) | ||
| if ok { | ||
| account := entry.(*core.AccountWithVolumes) |
There was a problem hiding this comment.
Should we update the cache after inserting in the database ?
paul-nicolas
approved these changes
Aug 16, 2023
flemzord
approved these changes
Aug 18, 2023
flemzord
pushed a commit
that referenced
this pull request
Dec 4, 2023
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.