Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging validators and validation as well as asyncValidators and asyncValidation #170

Closed
mohammedzamakhan opened this issue Oct 26, 2016 · 3 comments
Closed

Merging validators and validation as well as asyncValidators and asyncValidation #170

mohammedzamakhan opened this issue Oct 26, 2016 · 3 comments
Labels
enhancement

Comments

@mohammedzamakhan
Copy link
Contributor

It would be better to have just validators and asyncValidator like in angular-formly
@mohammedzamakhan mohammedzamakhan changed the title Merging validators and validation as well as asyncValidation and asyncValidation Merging validators and validation as well as asyncValidators and asyncValidation Oct 26, 2016
@aitboudad
Copy link
Member

can you explain more on this ?

@mohammedzamakhan
Copy link
Contributor Author

Instead of having validation: Validators.required, I can have validators: { validation: Validators.required}

Benefit: We now have validation property that can be used similar to angular-formly
http://docs.angular-formly.com/docs/field-configuration-object

We should always try to bridge the gap between angular 1 and 2 field configuration as much as possible

@mohammedzamakhan
Copy link
Contributor Author

Closing this as #165 will take care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aitboudad @mohammedzamakhan