Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra formly tags removal #225

Closed
mohammedzamakhan opened this issue Nov 5, 2016 · 5 comments
Closed

Extra formly tags removal #225

mohammedzamakhan opened this issue Nov 5, 2016 · 5 comments

Comments

@mohammedzamakhan
Copy link
Contributor

Analyze whether we can remove the extra component tags by any means.

Before:

screen shot 2016-11-03 at 10 17 18 am

After removal of tags:

screen shot 2016-11-03 at 10 17 43 am
@mohammedzamakhan
Copy link
Contributor Author

@formly-js/angular2-formly-core-team Need suggestions to tackle this issue.

@divyakumarjain
Copy link
Contributor

This is how Angular 2 recommends Components to be added to DOM. In Angular 1 we had a way but dont think there is a way in Angular 2.

Are we running into any issue because of this?

@mohammedzamakhan
Copy link
Contributor Author

@divyakumarjain look at the date of investment field above in both before and after pic

@divyakumarjain
Copy link
Contributor

Haven't tried earlier and also not sure how much rework is this but may be formly-field-input can be converted into a directive instead of Component?

@mohammedzamakhan
Copy link
Contributor Author

I don't think we can convert this into a directive, since directive won't contain a template 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@divyakumarjain @mohammedzamakhan