Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formly in Tabs #263

Closed
mohammedzamakhan opened this issue Nov 18, 2016 · 7 comments
Closed

Formly in Tabs #263

mohammedzamakhan opened this issue Nov 18, 2016 · 7 comments

Comments

@mohammedzamakhan
Copy link
Contributor

mohammedzamakhan commented Nov 18, 2016

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
Have two forms inside tabset doesn't allow the user to go back to Step 1 (first tab)

Expected behavior
It should work without any issues

Minimal reproduction of the problem with instructions
https://plnkr.co/edit/LjbRLPrbh0GI7kp7DiLf

@mohammedzamakhan mohammedzamakhan changed the title Formsly in Tabs Formly in Tabs Nov 18, 2016
@mohammedzamakhan
Copy link
Contributor Author

mohammedzamakhan commented Nov 18, 2016

@mohammedzamakhan
Copy link
Contributor Author

@franzeal issue created on ng-bootstrap module ng-bootstrap/ng-bootstrap#1069

@mohammedzamakhan
Copy link
Contributor Author

@franzeal I am closing this issue, as this is ng-bootstrap issue, I was able to get this running using ng2-bootstrap https://plnkr.co/edit/z31ngGCEwykcCqPuBOjM?p=preview

@franzeal
Copy link
Contributor

franzeal commented Nov 23, 2016

@mohammedzamakhan Unfortunately, even with ng2-bootstrap the tabs don't seem to behave correctly (though I'll probably explore this more, because the tabs are the only reason I'd have a dependency on either library): http://plnkr.co/edit/vp6koAP0m490Dp8hTdUJ?p=preview

Thank you very much, I appreciate that you shared the issue with ng-bootstrap folks and gave it a hard look.

@franzeal
Copy link
Contributor

franzeal commented Nov 30, 2016

Just to follow-up, I was able to get the idea here to work. I ended up implementing my own tabset and tab components and using a tabset service provided by the tabset and used by the tabs to associate them. Maybe there's a better way. This solves my immediate issue, wasn't much effort, and allows me to use tabs in a flexible manner within our forms.

@mohammedzamakhan
Copy link
Contributor Author

Can you give the plnkr with your implementation. We can put that example on the website

@franzeal
Copy link
Contributor

franzeal commented Dec 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants